Any chance we could get before/after screen recording of this in action? That'd make review easier ❤️

Before: https://cld.wthms.co/VbiBYh - slight colour change when putting fingers on items for scrolling

After: http://cld.wthms.co/LhbM5v - I deliberately put my fingers above the menu items while scrolling and no more colour changes.

Seems like Travis isn't happy ;) Thanks for the update @tofumatt

Travis was buggy with this PR and the failures are complaining about PHP files not in this change 🤷‍♂️

Just gonna merge because this works for me locally...

So I haven't tested this yet, but it sounds sad when reading this.

I actually use my phone (Samsung Galaxy S9+) with Samsung DeX for all of my development work. I hope hovering will still work on my phone. I don't want this disabled at all. It will be awful if :hover is disabled for mobile.

@shaunroselt could you share a specific example of this? With most phones, it's required to actually click something in order to open up a section, not hover over (you can't hover with a finger).

That said, the only change it that it doesn't show up as a different colour on mobile.

@shaunroselt could you share a specific example of this? With most phones, it's required to a

@jobthomas You can however hover with a mouse. I have an external monitor, keyboard and mouse plugged into my phone and then I use it like this. So I actually use the :hover on mobile with my mouse.

I plan on slowly upgrading all of my old websites to WordPress 5 and Gutenberg when it comes out as well as do all my future websites in WordPress 5 and Gutenberg. I definitely want hover to keep working on my phone. I have a mouse connected to my phone 70% of the time. So I don't really use a finger at all, but I do use a mouse. I have a Logitech G502 Mouse at home and a Cooler Master MS120 Mouse at work. I use them both with my phone.

Just as reference, the $break-medium is set to 782px. Based on what I can read, the Galaxy S9 is a higher resolution than that, so that would mean this pull request doesn't affect your device. The external monitor should also not be affected by this at all.

All this does is not change the colours of the hover option if the screen is less wide than 782px.

Just as reference, the $break-medium is set to 782px. Based on what I can read, the Galaxy S9 is a higher resolution than that, so that would mean this pull request doesn't affect your device. The external monitor should also not be affected by this at all.

All this does is not change the colours of the hover option if the screen is less wide than 782px.

@jobthomas Okay that sounds better. Thanks. I have a 1920x1080 monitor at home and work for my phone. My actual phone resolution is just a bit bigger than 1440p.

Thanks

I have a 1920x1080 monitor at home and work for my phone. My actual phone resolution is just a bit bigger than 1440p.

Nothing to worry then. It's only for devices smaller than that breakpoint.